Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix docker build on clean env #469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sirAndros
Copy link

Hello!
Currently it is not possible to just clone repo and run docker build . -t browsh.
This is not an actual pull request I'm only show you the changes which I have to make to make thinks works.
Thanks!

@tombh
Copy link
Member

tombh commented Feb 14, 2023

Ah, I think this is what /ctl.sh bundle_production_webextension is for? I just need to document it

@sirAndros
Copy link
Author

Yeah, if it can be used inside dockerfile.
And without chmod +x /build/ctl.sh I've got "Permission denied" error

@tombh
Copy link
Member

tombh commented Feb 14, 2023

Oh I mean, you have to run /ctl.sh bundle_production_webextension before the docker build command, then the XPI file is automatically copied in.

@sirAndros
Copy link
Author

sirAndros commented Feb 15, 2023

Maybe include it as step right into dockerfile?
Here my case: I wanted to check the app out, but it wants about 480MB of dependecies. Than I check docker, but there is no version for ARM64, so I decided to build it on my own as I usually do in such situations (normal workflow git clone => docker build & run), but it does not work.
This time I have some resources to read the README and DEV docs and even to debug docker build, but in ordinal situation I will just continue to work with lynx.
I belive that I'm not the only one who could skip a good app in such scenario because users usually as lazy as you can possibly imagine :)

@tombh
Copy link
Member

tombh commented Feb 15, 2023

That's very understandable. The thing is that I just don't have so much time for Browsh these days. And the less I work on it, the harder it is for me to make sure everything is as user friendly as possible.

I think the reason I don't include it in the Dockerfile is because there's different logic when publishing a new version of the Docker image, and when you just build the Docker image locally.

@sirAndros
Copy link
Author

I understand you very well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants